Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]Displaying multiple messages with the same content for a given a… #1106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX]Displaying multiple messages with the same content for a given a… #1106

wants to merge 1 commit into from
+2 −8

Conversation

christer77
Copy link
Member

Displaying multiple messages with the same content for a given action

Here are 2 cases that this PR solves:

  1. First case: After sending a message, and you have 2 or 3 tabs open, you keep that the message indicating that "the message is sent" is displayed several times on the other tabs open.

Ilistration:
01-first-case

  1. 2nd case: When deleting a message in inline mode, we have the message "Message deleted" which also comes up as many times.
    Ilistration:
    02-second-case

@PaulTGG
Copy link
Contributor

PaulTGG commented Jun 30, 2024

#991

@marclaporte marclaporte requested a review from kroky June 30, 2024 19:41
kroky
kroky reviewed Jul 8, 2024
View reviewed changes
modules/core/site.js Outdated Show resolved Hide resolved
@marclaporte marclaporte requested a review from kroky August 8, 2024 21:43
@christer77 christer77 force-pushed the Fix-Displaying-multiple-messages-with-the-same-content-for-a-given-action branch from d12248b to c18a1ca Compare August 28, 2024 15:05
@PaulTGG
Copy link
Contributor

PaulTGG commented Aug 30, 2024

👀

@Baraka24 Baraka24 mentioned this pull request Sep 28, 2024
Open
@christer77 christer77 force-pushed the Fix-Displaying-multiple-messages-with-the-same-content-for-a-given-action branch from c18a1ca to 89ddfb3 Compare October 22, 2024 15:03
@christer77 christer77 force-pushed the Fix-Displaying-multiple-messages-with-the-same-content-for-a-given-action branch from 89ddfb3 to 8a14b29 Compare October 23, 2024 07:15
@christer77 christer77 requested review from kroky and removed request for kroky October 31, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroky kroky Awaiting requested review from kroky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christer77 @PaulTGG @kroky